Bugfix: Simplenote converter handles empty notes correctly #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanharwara
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Hi, thanks for the PR!
Looks like lint is failing (https://github.com/standardnotes/app/actions/runs/7636015424/job/20817657669?pr=2793#step:5:57) Please fix those issues.
Also, please run yarn test SimplenoteConverter in packages/ui-services and make sure that passes.
|
@amanharwara Thanks for the heads up! I was hasty to get this out last night so I only tested it in a REPL. The new version should avoid those Lint errors. Tests pass on my machine. |
mmorella-dev
force-pushed
the
fix-simplenote-null-check
branch
from
d0efd04
to
f9615bf
Compare
It's valid for entry.content to be an empty string, so the truthiness check discards valid inputs where content is empty. Change this to a null check. Fixes standardnotes/forum#3462
mmorella-dev
force-pushed
the
fix-simplenote-null-check
branch
2 times, most recently
from
08bd073
to
96e4e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes standardnotes/forum#3462
The current implementation of SimplenoteConverter uses the following helper function to validate notes.json:
Because
&&is used here instead of a null check, this function returns false whencontentis an empty string"". This can trivially occur in notes where the user clicked "New Note" but did not enter any data. For example:{ "id": "e5ae4e85-a6a4-45d9-8994-6e693483f679", "content": "", "creationDate": "2024-01-02T01:37:22.615Z", "lastModified": "2024-01-02T01:38:26.662Z" }This PR rewrites the function to instead use
Object.prototype.hasOwnPropertyto query for the existence of each property, which produces the expected output whencontentis an empty string.